PAYARA-2545 upgrade microprofile config to 1.2.1 #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test |
|
Quick build and test passed! |
lprimak
changed the title
lprimak
previously requested changes
Apr 23, 2018
| public Class convert(String string) { | ||
| if (string == null || string.equals(ConfigProperty.UNCONFIGURED_VALUE)) return null; | ||
| try { | ||
| return Class.forName(string,true,Thread.currentThread().getContextClassLoader()); |
There was a problem hiding this comment.
- Use Utility.getClassLoader()/Utility.setContextClassLoader() as it works correctly w/Security Manager
Spaces between commas (string, true, etc)
Make parameter meaningful
| return result; | ||
| } | ||
|
|
||
| private Object convertViaConstructor(String string) { |
There was a problem hiding this comment.
meaningful parameter / result variable name
| Object result = null; | ||
| try { | ||
| // need to do common sense reflected conversion | ||
| Method method = clazz.getMethod("parse",CharSequence.class); |
| try { | ||
| // need to do common sense reflected conversion | ||
| Method method = clazz.getMethod("parse",CharSequence.class); | ||
| result = method.invoke(null,string); |
|
jenkins test |
1 similar comment
|
jenkins test |
|
Quick build and test passed! |
arjantijms
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.