PAYARA-2677 Reset thread-context ClassLoader after de-serialization for Payara 4 #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins quick test payara 4 |
|
Quick build and test passed! |
lprimak
force-pushed
the
PAYARA-2677-ResetSerializeClassLoader-p4
branch
from
f2e74ce
to
4a40d34
Compare
|
jenkins quick test payara 4 |
|
Quick build and test passed! |
Cousjava
previously requested changes
Apr 12, 2018
| @@ -68,6 +68,19 @@ public void close() { | |||
| private final InvocationManager invMgr; | |||
| } | |||
|
|
|||
| @RequiredArgsConstructor | |||
There was a problem hiding this comment.
Remove lombok, update copyright
There was a problem hiding this comment.
Copyright updated.
Once again, you can't just "remove lombok" I will create a massive PR that replaces lombok with boilerplate and then an informed decision can be made.
For now, Lombok stays. Can't hold up a regression issue for this
|
jenkins quick test payara 4 |
|
Quick build and test passed! |
smillidge
approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2604 for Payara 4