Payara 1925 jacc per app #2651
Merged
Payara 1925 jacc per app #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added interfaces in the Payara API, and implemented these within Payara.
|
Note that main functional changes are in: |
|
Great to see this at last! |
Thanks! Very happy to have been able to implement this too. It's approximately the approach we discussed all that time back in the JACC group with Ron. If the JACC spec starts again I'd like to present this work as the POC to potentially base the spec revision on. |
MattGill98
approved these changes
Apr 19, 2018
| @@ -2606,6 +2609,14 @@ public boolean isJaxrsRolesAllowedEnabled() { | |||
| public void setJaxrsRolesAllowedEnabled(boolean jaxrsRolesAllowedEnabled) { | |||
| this.jaxrsRolesAllowedEnabled = jaxrsRolesAllowedEnabled; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Can these have an @OverRide?
| private void createPolicyContextDirectory() { | ||
|
|
||
| String contextDirectoryName = getContextDirectoryName(); | ||
| File d = new File(contextDirectoryName); | ||
| File contectDirectory = new File(contextDirectoryName); |
lprimak
approved these changes
Apr 23, 2018
|
jenkins test |
|
Quick build and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.