Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2708 Cleanup code in nucleus/admin/cli #2671

Merged

Conversation

Cousjava
Copy link
Contributor

Resolves warnings and code smells from sonarcloud, excluding duplications and cognitively complexity

Resolves warnings and code smells from sonarcloud, excluding duplications and cognitively complexity
@Cousjava Cousjava added this to the Payara 5.182 milestone Apr 25, 2018
@Cousjava
Copy link
Contributor Author

Jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

}
}
private static String truncate(String arg, int max) {
int len = arg.length();

if(len < 20)
if(len < 20){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have addressed formatting here right away too ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had probably missed some, but I can always have another go round at some point

@arjantijms arjantijms merged commit 04b83d1 into payara:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants