Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2744 Monitoring REST API bulk reading #2617 #2697

Merged
merged 2 commits into from May 16, 2018

Conversation

kvalev
Copy link
Contributor

@kvalev kvalev commented May 1, 2018

No description provided.

@kvalev kvalev changed the title Monitoring REST AI bulk reading #2617 Monitoring REST API bulk reading #2617 May 1, 2018
@smillidge
Copy link
Contributor

Jenkins test

Copy link
Contributor

@smillidge smillidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution just minor changes for the copyright header.

@@ -0,0 +1,88 @@
package fish.payara.monitoring.rest.app.handler;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the copyright header

@@ -0,0 +1,102 @@
package fish.payara.monitoring.rest.app.resource;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the copyright header

@smillidge smillidge added the PR: Awaiting CLA Contributor does not have a CLA or has submitted an unconfirmed CLA. label May 3, 2018
@smillidge
Copy link
Contributor

Thanks for the awesome work.
Can you also sign a CLA so we have one on record to accept the enhancement.
https://github.com/payara/Payara/blob/master/.github/CONTRIBUTING.md once a CLA is on file we will also send a Payara goody bag.

@payara-ci
Copy link
Contributor

Quick build and test passed!

@smillidge smillidge added PR: CLA CLA submitted on PR by the contributor and removed PR: Awaiting CLA Contributor does not have a CLA or has submitted an unconfirmed CLA. labels May 4, 2018
@smillidge
Copy link
Contributor

Jenkins test

@smillidge smillidge added this to the Payara 5.182 milestone May 4, 2018
@payara-ci
Copy link
Contributor

Quick build and test passed!

@kvalev
Copy link
Contributor Author

kvalev commented May 14, 2018

Is there anything blocking this PR?

@smillidge
Copy link
Contributor

Nope just some bookkeeping on our side to create an issue number for the release notes and a corresponding PR into 4.x branch which we will do.

@smillidge smillidge changed the title Monitoring REST API bulk reading #2617 PAYARA-2744 Monitoring REST API bulk reading #2617 May 16, 2018
@smillidge
Copy link
Contributor

jenkins test

@payara-ci
Copy link
Contributor

Quick build and test passed!

@smillidge smillidge merged commit 48a8e19 into payara:master May 16, 2018
MeroRai pushed a commit to MeroRai/Payara that referenced this pull request May 29, 2018
* Monitoring REST AI bulk reading

* Copyright header
@OndroMih
Copy link
Contributor

OndroMih commented Jun 4, 2018

Hi @kvalev, can you please explain shortly how to use this feature?

@kvalev
Copy link
Contributor Author

kvalev commented Jun 5, 2018

It basically allows bulk reading of monitoring data, so instead of reading it one by one

curl -X GET \
  http://localhost:4848/rest-monitoring/rest/read/java.lang:type=Memory
curl -X GET \
  http://localhost:4848/rest-monitoring/rest/read/java.lang:type=Runtime

you can now do it within a single request:

curl -X POST \
  http://localhost:4848/rest-monitoring/rest/ \
  -H 'Content-Type: application/json' \
  -d '[{"type":"read","mbean":"java.lang:type=Runtime","attribute":["Uptime"]},{"type":"read","mbean":"java.lang:type=Memory","attribute":["HeapMemoryUsage","NonHeapMemoryUsage"]},{"type":"read","mbean":"java.lang:type=Threading","attribute":["ThreadCount"]},{"type":"read","mbean":"java.lang:type=OperatingSystem","attribute":["ProcessCpuTime"]}]'

This will allow integrating it with the jolokia module in metricbeat, although I havent tested it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: CLA CLA submitted on PR by the contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants