PAYARA-2547 Implement MicroProfile OpenTracing 1.0 #2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandrex247
changed the title
|
Jenkins test please |
MattGill98
reviewed
May 29, 2018
| completed = false; | ||
| } | ||
|
|
||
| private void handleRequestEvent(RequestTraceSpan span) { |
There was a problem hiding this comment.
Could the first function call the overloaded one?
There was a problem hiding this comment.
Not straight-forwardly as you'd lose the precision of nanoTime converting to milliseconds.
| @@ -171,16 +222,16 @@ public boolean isStarted() { | |||
|
|
|||
| /** | |||
| * Returns a list of all the events that make up the trace. | |||
| * @return | |||
| * @return | |||
There was a problem hiding this comment.
Can this be corrected to be described in the @return?
| * See {@link java.time.Instant#now()} for how this time is generated. | ||
| * @return | ||
| * @return |
|
Jenkins test please |
|
Quick build and test failed! |
…github.com:Pandrex247/Payara into PAYARA-2547-Implement-MicroProfile-OpenTracing-1.0
|
Jenkins test please |
|
Quick build and test passed! |
Pandrex247
deleted the
PAYARA-2547-Implement-MicroProfile-OpenTracing-1.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates OpenTracing into the Request Tracing Service.
Allows users to instrument their code for tracing with an annotation
@Traced, and to inject a Tracer object to manually start and configure Spans themselves.Currently not supported in this PR: Injection and Extraction (used for cross-process propagation).
Relies on payara/Payara_PatchedProjects#157, and payara/Payara_PatchedProjects#158