PAYARA-2824 Fixes in CDI event notif. #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by:Ondrej Mihalyi <ondrej.mihalyi@payara.fish>
Pandrex247
approved these changes
Jun 6, 2018
lprimak
approved these changes
Jun 6, 2018
|
jenkins test |
|
Quick build and test passed! |
Signed-off-by:Ondrej Mihalyi <ondrej.mihalyi@payara.fish>
|
Hi @lprimak, I added one more null check which I missed to commit. |
|
isApplicationEnabled() definitely checks / ignores null argument... not sure that's necessary, but doesn't hurt though |
|
Jenkins test please |
|
Quick build and test passed! |
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Jun 18, 2018
PAYARA-2824 Fixes in CDI event notif.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unexpected null values when CDI event triggered from server context and not from app context