New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2824 Fixes in CDI event notif. #2820

Merged
merged 2 commits into from Jun 18, 2018

Conversation

Projects
None yet
5 participants
@OndrejM
Contributor

OndrejM commented Jun 6, 2018

Unexpected null values when CDI event triggered from server context and not from app context

PAYARA-2824 Fixes in CDI event notif.
Signed-off-by:Ondrej Mihalyi <ondrej.mihalyi@payara.fish>

@OndrejM OndrejM requested review from mulderbaba, arjantijms and Pandrex247 Jun 6, 2018

@lprimak

lprimak approved these changes Jun 6, 2018

@lprimak

This comment has been minimized.

Show comment
Hide comment
@lprimak

lprimak Jun 6, 2018

Contributor

jenkins test

Contributor

lprimak commented Jun 6, 2018

jenkins test

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jun 6, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Jun 6, 2018

Quick build and test passed!

PAYARA-2824 Fixes in CDI event notif.
Signed-off-by:Ondrej Mihalyi <ondrej.mihalyi@payara.fish>
@OndrejM

This comment has been minimized.

Show comment
Hide comment
@OndrejM

OndrejM Jun 7, 2018

Contributor

Hi @lprimak, I added one more null check which I missed to commit.

Contributor

OndrejM commented Jun 7, 2018

Hi @lprimak, I added one more null check which I missed to commit.

@MeroRai MeroRai added the v:Payara-5 label Jun 7, 2018

@MeroRai MeroRai added this to the Payara 5.183 milestone Jun 7, 2018

@lprimak

This comment has been minimized.

Show comment
Hide comment
@lprimak

lprimak Jun 7, 2018

Contributor

isApplicationEnabled() definitely checks / ignores null argument... not sure that's necessary, but doesn't hurt though

Contributor

lprimak commented Jun 7, 2018

isApplicationEnabled() definitely checks / ignores null argument... not sure that's necessary, but doesn't hurt though

@Pandrex247

This comment has been minimized.

Show comment
Hide comment
@Pandrex247

Pandrex247 Jun 15, 2018

Contributor

Jenkins test please

Contributor

Pandrex247 commented Jun 15, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jun 15, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Jun 15, 2018

Quick build and test passed!

@Pandrex247 Pandrex247 merged commit 57f8e1a into payara:master Jun 18, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details

Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment