New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2874 Enabling Security Manager Causes Log Errors #2883

Merged
merged 1 commit into from Jun 22, 2018

Conversation

Projects
None yet
3 participants
@MattGill98
Contributor

MattGill98 commented Jun 21, 2018

This fix stops the NullPointerExceptions, and I don't see any obvious problem with the contextID being null in the first place. Needs a review to make sure this is the case.

@MattGill98 MattGill98 added this to the Payara 5.183 milestone Jun 21, 2018

@MattGill98 MattGill98 self-assigned this Jun 21, 2018

@MattGill98 MattGill98 requested a review from arjantijms Jun 21, 2018

@MattGill98

This comment has been minimized.

Show comment
Hide comment
@MattGill98

MattGill98 Jun 21, 2018

Contributor

jenkins test please

Contributor

MattGill98 commented Jun 21, 2018

jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jun 21, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Jun 21, 2018

Quick build and test passed!

@arjantijms

This comment has been minimized.

Show comment
Hide comment
@arjantijms

arjantijms Jun 22, 2018

Contributor

@MattGill98 I'll do some checks to be sure, thx for the fix so far!

Contributor

arjantijms commented Jun 22, 2018

@MattGill98 I'll do some checks to be sure, thx for the fix so far!

@arjantijms arjantijms merged commit 4b50848 into payara:master Jun 22, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment