PAYARA-2923 Fix OpenTracing IllegalStateException #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGill98
reviewed
Jul 23, 2018
| beanManager = CDI.current().getBeanManager(); | ||
| } catch (IllegalStateException ise) { | ||
| // *Should* only get here if CDI hasn't been initialised, indicating that the app isn't using it | ||
| logger.log(Level.FINE, "Error getting Bean Manager, presumably due to this application not using CDI", |
There was a problem hiding this comment.
Is this log message not going to get logged twice?
There was a problem hiding this comment.
Yes, but it is possible for the two filter methods to execute on separate threads.
MattGill98
approved these changes
Jul 31, 2018
MattGill98
approved these changes
Jul 31, 2018
|
Jenkins test please |
|
Quick build and test passed! |
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Aug 15, 2018
PAYARA-2923 Fix OpenTracing IllegalStateException
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Aug 15, 2018
PAYARA-2923 Fix OpenTracing IllegalStateException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an IllegalStateException that can occur when a JAX-RS method of an app with no CDI beans is called with request tracing enabled.