New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2923 Fix OpenTracing IllegalStateException #2974

Merged
merged 2 commits into from Aug 6, 2018

Conversation

Projects
None yet
4 participants
@Pandrex247
Contributor

Pandrex247 commented Jul 20, 2018

Fixes an IllegalStateException that can occur when a JAX-RS method of an app with no CDI beans is called with request tracing enabled.

beanManager = CDI.current().getBeanManager();
} catch (IllegalStateException ise) {
// *Should* only get here if CDI hasn't been initialised, indicating that the app isn't using it
logger.log(Level.FINE, "Error getting Bean Manager, presumably due to this application not using CDI",

This comment has been minimized.

@MattGill98

MattGill98 Jul 23, 2018

Contributor

Is this log message not going to get logged twice?

@MattGill98

MattGill98 Jul 23, 2018

Contributor

Is this log message not going to get logged twice?

This comment has been minimized.

@Pandrex247

Pandrex247 Jul 30, 2018

Contributor

Yes, but it is possible for the two filter methods to execute on separate threads.

@Pandrex247

Pandrex247 Jul 30, 2018

Contributor

Yes, but it is possible for the two filter methods to execute on separate threads.

@mulderbaba mulderbaba added this to the Payara 5.183 milestone Jul 28, 2018

@Pandrex247

This comment has been minimized.

Show comment
Hide comment
@Pandrex247

Pandrex247 Aug 1, 2018

Contributor

Jenkins test please

Contributor

Pandrex247 commented Aug 1, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Aug 1, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Aug 1, 2018

Quick build and test passed!

@Pandrex247 Pandrex247 merged commit bc40643 into payara:master Aug 6, 2018

3 of 4 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details

@Pandrex247 Pandrex247 deleted the Pandrex247:PAYARA-2923 branch Aug 6, 2018

Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Aug 15, 2018

Merge pull request payara#2974 from Pandrex247/PAYARA-2923
PAYARA-2923 Fix OpenTracing IllegalStateException

Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Aug 15, 2018

Merge pull request payara#2974 from Pandrex247/PAYARA-2923
PAYARA-2923 Fix OpenTracing IllegalStateException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment