Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-2926 Cookie session persistence type does not throw exception … #2980

Merged
merged 2 commits into from Aug 20, 2018
Merged

PAYARA-2926 Cookie session persistence type does not throw exception … #2980

merged 2 commits into from Aug 20, 2018

Conversation

MarkWareham
Copy link
Contributor

…after maxSessions reached

@MarkWareham
Copy link
Contributor Author

Jenkins test please

Cousjava
Cousjava reviewed Jul 23, 2018
View reviewed changes
Copy link
Contributor

@Cousjava Cousjava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be part of the synchronised block?

@MarkWareham
Copy link
Contributor Author

MarkWareham commented Jul 23, 2018 •
edited

Potentially. I've used the same code from the other managers. So if needed, that should be part of a larger change to all the managers

@MarkWareham
Copy link
Contributor Author

Jenkins test please

1 similar comment
@MarkWareham
Copy link
Contributor Author

Jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

Cousjava
Cousjava suggested changes Jul 27, 2018
View reviewed changes
Copy link
Contributor

@Cousjava Cousjava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Payara copyright need adding

@mulderbaba mulderbaba added this to the Payara 5.183 milestone Jul 28, 2018
This was referenced Aug 18, 2018
Merged
Closed
@Pandrex247 Pandrex247 merged commit 035b500 into payara:master Aug 20, 2018
@MarkWareham MarkWareham deleted the PAYARA-2926 branch October 25, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cousjava Cousjava Cousjava requested changes

Assignees

@MarkWareham MarkWareham

Labels
None yet
Projects
None yet
Milestone
Payara 5.183
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MarkWareham @payara-ci @Cousjava @mulderbaba @Pandrex247