Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-3114 Concurrent Modification Exception when trying to access an active span programmatically. - Payara4 #3256

Merged
merged 1 commit into from Oct 11, 2018
Merged

PAYARA-3114 Concurrent Modification Exception when trying to access an active span programmatically. - Payara4 #3256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Expand Up @@ -20,3 +20,4 @@ appserver/extras/arquillian-containers/payara-common/dependency-reduced-pom.xml
/appserver/tests/quicklook/cluster/clustersetup/nbproject/
/nucleus/payara-modules/service-exemplar/nbproject/
/nucleus/admin/server-mgmt/nbproject/
appserver/tests/quicklook/quicklook_summary.txt
5 changes: 0 additions & 5 deletions appserver/tests/quicklook/quicklook_summary.txt
View file
Open in desktop

This file was deleted.

7 changes: 4 additions & 3 deletions ...eus/payara-modules/opentracing-adapter/src/main/java/fish/payara/opentracing/OTScope.java
View file
Open in desktop
Expand Up @@ -48,7 +48,7 @@
import java.util.Map;

/**
* Implementation of Scope from Opentracing.
* Implementation of Scope from OpenTracing.
*
* @author jonathan coustick
* @since 5.183
Expand All @@ -70,7 +70,8 @@ public void close() {
if (allSpans.get(span)){
span.finish();
}
allSpans.remove(span);//prevents scope holding on a reference to old spans
// Prevent scope holding on a reference to old spans
keys.remove();
}
}

Expand All @@ -79,7 +80,7 @@ public Span span() {
return currentSpan;
}

//package private - used only by ScopeManager
// Package private - used only by ScopeManager
void setSpan(Span span, Boolean finishOnClose){
allSpans.put(span, finishOnClose);
currentSpan = span;
Expand Down