New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3247 Add NPN Version Switch #3414

Merged
merged 5 commits into from Nov 14, 2018

Conversation

@MattGill98
Member

MattGill98 commented Nov 12, 2018

These changes include several NPN jars, and code to dynamically select one when the asadmin start script runs. Ran manual tests:

  • start-domain and then ping https://localhost:8181/ with OpenJDK 8u72 through to 8u192.
  • Starting 8u192 instance from 8u181 DAS admin console.
  • Payara Micro and ping https://localhost:8181/ on 8u192 (Shouldn't be any different but who knows).

@MattGill98 MattGill98 added this to the Payara 5.184 milestone Nov 12, 2018

@MattGill98 MattGill98 self-assigned this Nov 12, 2018

@MattGill98 MattGill98 requested a review from arjantijms Nov 12, 2018

@MattGill98

This comment has been minimized.

Member

MattGill98 commented Nov 12, 2018

jenkins test please

@MattGill98 MattGill98 requested a review from MeroRai Nov 13, 2018

@smillidge

Looks like a pretty neat solution. Although there will be a level of maintenance required to keep it up to date. We also need to remember to rip it out as part of the JDK 11+ work.

@lprimak

This comment has been minimized.

Contributor

lprimak commented Nov 13, 2018

Any chance this all can be avoided just by using version support that now exists in the jvm-options tag in domain.xml?

@MattGill98 MattGill98 force-pushed the MattGill98:PAYARA-3247-Add-NPN-Version-Switch branch from 101fb37 to ae3e828 Nov 14, 2018

@MattGill98

This comment has been minimized.

Member

MattGill98 commented Nov 14, 2018

I've switched out the hard coded logic for the version support in the domain.xml, and fixed a bug that existed related to subversion comparison. Thanks @lprimak for pointing that out!

@MattGill98

This comment has been minimized.

Member

MattGill98 commented Nov 14, 2018

@smillidge the new changes should make this a bit more maintainable, as it no longer affects any Java 9+ versions. The only reason we'd need to update this would be for new 8u192+ breaking changes.

@MattGill98

This comment has been minimized.

Member

MattGill98 commented Nov 14, 2018

jenkins test please

@Pandrex247 Pandrex247 merged commit ff92bde into payara:master Nov 14, 2018

1 check passed

Payara Quick Build and Test Quick build and test passed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment