New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAYARA-1165 allow setting of context root on Payara Micro deployments #3682
Conversation
jenkins test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows?
...o/payara-micro-core/src/main/java/fish/payara/micro/cmd/options/DeploymentFileValidator.java
Outdated
Show resolved
Hide resolved
...ras/payara-micro/payara-micro-core/src/main/java/fish/payara/micro/impl/PayaraMicroImpl.java
Outdated
Show resolved
Hide resolved
@smillidge --contextroot is ignored when using --deployFromGAV. Changing the contextroot logic in fish.payara.micro.impl.PayaraMicroImpl#getGAVURLs to the following statements fixes this.
|
@rdebusscher good catch I will fix that |
ead9d58
to
e82ef2e
Compare
Now works with deploy from Gav and uses File.pathseparator so will work on windows |
jenkins test please |
This PR allows to set the context path in two ways:
--contextroot
--deploy
with:root
after the file nameBoth examples configure a effective root context of
/mycontext/
When both are specified the root given with
--deploy
takes precedence. The--contextroot
applies to the first given--deploy
that does not specify its context path directly.This will deploy
app1
in/foo/
andapp2
in/bar/
.Note:
--deploy app.war:/
is the same as--deploy app.war:
which all deploy in the root/
.That means a leading
/
is not necessary but can be given. In contrast a tailing/
should not be given and seems to not work. While the configuration keeps it as"Context Root": "/foo/"
browsing to/foo
or/foo/
forwards to/foo//
which fails to resolve to the expected page.