Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3451 Managed Scheduled Executor Service doesn't execute tasks from versioned applications #3693

Merged
merged 4 commits into from Feb 22, 2019

Conversation

Projects
None yet
5 participants
@jGauravGupta
Copy link
Contributor

jGauravGupta commented Feb 5, 2019

Github issue : #3630

@jGauravGupta jGauravGupta added this to the 5.191 milestone Feb 5, 2019

@jGauravGupta jGauravGupta self-assigned this Feb 5, 2019

@jGauravGupta

This comment has been minimized.

Copy link
Contributor Author

jGauravGupta commented Feb 6, 2019

jenkins test please

@smillidge
Copy link
Contributor

smillidge left a comment

What is registrationname? I'm a bit worried by adding things into component invocation. Are you sure all these parts are non null as they may often be referenced in other code?

It seems like a large system wide change for a problem in a specific subsystem?

@jGauravGupta

This comment has been minimized.

Copy link
Contributor Author

jGauravGupta commented Feb 8, 2019

appName is duplicated for versioned application but registrationName is unique id (versioned name) for deployed versioned application. I covered each client invocation to make sure non-null value.

PAYARA-3451 ticket can be fixed by either caching registrationName value in ComponentInvocation or fetching it's value via Jndi in ContextSetupProviderImpl#setup.

@jGauravGupta

This comment has been minimized.

Copy link
Contributor Author

jGauravGupta commented Feb 8, 2019

To showcase the alternate fix to fetch registrationName value via Jndi, I have created the PR #3707 .

Although PR #3693 involves changes in many components but caching the unique id.

@Pandrex247 Pandrex247 merged commit 398fa8a into payara:master Feb 22, 2019

1 check passed

Payara Quick Build and Test Quick build and test passed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.