Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-3451 Managed Scheduled Executor Service doesn't execute tasks from versioned applications #3693

Merged
merged 4 commits into from Feb 22, 2019
Merged

PAYARA-3451 Managed Scheduled Executor Service doesn't execute tasks from versioned applications #3693

merged 4 commits into from Feb 22, 2019

Conversation

jGauravGupta
Copy link
Contributor

Github issue : #3630

@jGauravGupta jGauravGupta added this to the 5.191 milestone Feb 5, 2019
@jGauravGupta jGauravGupta self-assigned this Feb 5, 2019
@jGauravGupta
Copy link
Contributor Author

jenkins test please

smillidge
smillidge reviewed Feb 7, 2019
View reviewed changes
Copy link
Contributor

@smillidge smillidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is registrationname? I'm a bit worried by adding things into component invocation. Are you sure all these parts are non null as they may often be referenced in other code?

It seems like a large system wide change for a problem in a specific subsystem?

@jGauravGupta
Copy link
Contributor Author

appName is duplicated for versioned application but registrationName is unique id (versioned name) for deployed versioned application. I covered each client invocation to make sure non-null value.

PAYARA-3451 ticket can be fixed by either caching registrationName value in ComponentInvocation or fetching it's value via Jndi in ContextSetupProviderImpl#setup.

@jGauravGupta
Copy link
Contributor Author

jGauravGupta commented Feb 8, 2019 •
edited

To showcase the alternate fix to fetch registrationName value via Jndi, I have created the PR #3707 .

Although PR #3693 involves changes in many components but caching the unique id.

@jGauravGupta jGauravGupta mentioned this pull request Feb 14, 2019
Closed
@Pandrex247 Pandrex247 mentioned this pull request Feb 20, 2019
Merged
@Pandrex247 Pandrex247 merged commit 398fa8a into payara:master Feb 22, 2019
@OndroMih OndroMih mentioned this pull request Mar 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smillidge smillidge smillidge left review comments

@svendiedrichsen svendiedrichsen svendiedrichsen left review comments

@Pandrex247 Pandrex247 Pandrex247 approved these changes

@MattGill98 MattGill98 MattGill98 approved these changes

Assignees

@jGauravGupta jGauravGupta

Labels
None yet
Projects
None yet
Milestone
5.191
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jGauravGupta @smillidge @svendiedrichsen @Pandrex247 @MattGill98