PAYARA-3261 OpenTracing 1.3 #3750
Conversation
…l executor tracing
| Traced.class, "value", resourceInfo, boolean.class) | ||
| .orElse(tracedAnnotation.value())) { | ||
| // If there is no matching skip pattern and no traced annotation, or if there is there is no matching skip | ||
| // pattern and a traced annotation set to true (via annotation or config override) |
There was a problem hiding this comment.
This method is quite complex. Could use the logical separation by the comments as points for extracting methods. Just an observation, not a request to change now.
There was a problem hiding this comment.
In reference to the if block? Or the method itself? Because if the latter it's not that complex? Everything above the if is just variable initialisation.
There was a problem hiding this comment.
Note that on testing this PR a REST client TCK test fails. Is this relevant?
[ERROR] Tests run: 66, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 104.452 s <<< FAILURE! - in TestSuite
[ERROR] canInvokeMethodOnSubResourceInterface(org.eclipse.microprofile.rest.client.tck.SubResourceTest) Time elapsed: 0.296 s <<< FAILURE!
java.lang.UnsupportedOperationException: Not a resource method.
at org.eclipse.microprofile.rest.client.tck.SubResourceTest.canInvokeMethodOnSubResourceInterface(SubResourceTest.java:54)
...main/java/fish/payara/microprofile/opentracing/jaxrs/JaxrsContainerRequestTracingFilter.java
Show resolved
Hide resolved
Not seen before, so perhaps a legitimate failure |
...java/fish/payara/requesttracing/jaxrs/client/decorators/JaxrsInvocationBuilderDecorator.java
Outdated
Show resolved
Hide resolved
|
MicroProfile Rest Client should now be fixed - my fix to the web decorator revealed a flaw in the web decorator which I then had to fix. |
|
Jenkins test please |
|
D'oh! Test failed because Jersey hasn't been patched yet. |
|
Jenkins test please |
1 similar comment
|
Jenkins test please |
…g-1.3 PAYARA-3261 OpenTracing 1.3
Provides support for OpenTracing 1.3
Requires a patch to Jersey to account for changes in MicroProfile Rest Client, PR here: payara/patched-src-jersey#12