Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3261 OpenTracing 1.3 #3750

Merged
merged 12 commits into from Feb 25, 2019

Conversation

Projects
None yet
4 participants
@Pandrex247
Copy link
Member

Pandrex247 commented Feb 19, 2019

Provides support for OpenTracing 1.3

  • Skip Patterns
  • Operation Name Providers
  • MicroProfile Endpoints no longer Traced
  • Extra Exception Logging
  • MicroProfile Rest Client Support

Requires a patch to Jersey to account for changes in MicroProfile Rest Client, PR here: payara/patched-src-jersey#12

@Pandrex247 Pandrex247 requested review from MattGill98 and Cousjava Feb 20, 2019

Traced.class, "value", resourceInfo, boolean.class)
.orElse(tracedAnnotation.value())) {
// If there is no matching skip pattern and no traced annotation, or if there is there is no matching skip
// pattern and a traced annotation set to true (via annotation or config override)

This comment has been minimized.

@MarkWareham

MarkWareham Feb 20, 2019

Contributor

This method is quite complex. Could use the logical separation by the comments as points for extracting methods. Just an observation, not a request to change now.

This comment has been minimized.

@Pandrex247

Pandrex247 Feb 21, 2019

Author Member

In reference to the if block? Or the method itself? Because if the latter it's not that complex? Everything above the if is just variable initialisation.

@MattGill98
Copy link
Member

MattGill98 left a comment

Note that on testing this PR a REST client TCK test fails. Is this relevant?

[ERROR] Tests run: 66, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 104.452 s <<< FAILURE! - in TestSuite
[ERROR] canInvokeMethodOnSubResourceInterface(org.eclipse.microprofile.rest.client.tck.SubResourceTest)  Time elapsed: 0.296 s  <<< FAILURE!
java.lang.UnsupportedOperationException: Not a resource method.
	at org.eclipse.microprofile.rest.client.tck.SubResourceTest.canInvokeMethodOnSubResourceInterface(SubResourceTest.java:54)
Show resolved Hide resolved ...a/microprofile/opentracing/jaxrs/JaxrsContainerRequestTracingFilter.java
Show resolved Hide resolved nucleus/pom.xml Outdated
@MarkWareham

This comment has been minimized.

Copy link
Contributor

MarkWareham commented Feb 20, 2019

Note that on testing this PR a REST client TCK test fails. Is this relevant?

[ERROR] Tests run: 66, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 104.452 s <<< FAILURE! - in TestSuite
[ERROR] canInvokeMethodOnSubResourceInterface(org.eclipse.microprofile.rest.client.tck.SubResourceTest)  Time elapsed: 0.296 s  <<< FAILURE!
java.lang.UnsupportedOperationException: Not a resource method.
	at org.eclipse.microprofile.rest.client.tck.SubResourceTest.canInvokeMethodOnSubResourceInterface(SubResourceTest.java:54)

Not seen before, so perhaps a legitimate failure

@mulderbaba
Copy link
Member

mulderbaba left a comment

license plates need revising.

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Feb 22, 2019

MicroProfile Rest Client should now be fixed - my fix to the web decorator revealed a flaw in the web decorator which I then had to fix.

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Feb 22, 2019

Jenkins test please

@Pandrex247 Pandrex247 requested a review from MattGill98 Feb 22, 2019

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Feb 22, 2019

D'oh! Test failed because Jersey hasn't been patched yet.

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Feb 22, 2019

Jenkins test please

1 similar comment
@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Feb 24, 2019

Jenkins test please

@Pandrex247 Pandrex247 merged commit 56be235 into payara:master Feb 25, 2019

59 checks passed

Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/javaee-api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details

@Pandrex247 Pandrex247 deleted the Pandrex247:PAYARA-3261-OpenTracing-1.3 branch Feb 25, 2019

Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.