New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAYARA-3440 EJB REST based remoting #3758
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins test please |
MattGill98
approved these changes
Feb 21, 2019
Cousjava
approved these changes
Feb 22, 2019
Jenkins test please |
Jenkins test please |
Jenkins test please |
arjantijms
changed the title
PAYARA-3440 Formatting and variable renaming only
PAYARA-3440 EJB REST based remoting
Feb 25, 2019
Jenkins test please |
Pandrex247
reviewed
Feb 25, 2019
...b-rest-remoting/admin/src/main/java/fish/payara/ejb/rest/admin/DisableEjbInvokerCommand.java
Show resolved
Hide resolved
...jb-rest-remoting/admin/src/main/java/fish/payara/ejb/rest/admin/EnableEjbInvokerCommand.java
Outdated
Show resolved
Hide resolved
Pandrex247
reviewed
Feb 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More eyebrow raisers
...ejb/ejb-rest-remoting/client/src/main/java/fish/payara/ejb/rest/client/RemoteEJBContext.java
Outdated
Show resolved
Hide resolved
...ejb/ejb-rest-remoting/client/src/main/java/fish/payara/ejb/rest/client/RemoteEJBContext.java
Outdated
Show resolved
Hide resolved
...ejb/ejb-rest-remoting/client/src/main/java/fish/payara/ejb/rest/client/RemoteEJBContext.java
Show resolved
Hide resolved
Conflicts: nucleus/admin/template/pom.xml nucleus/admin/template/src/main/assembly/nucleus-domain.xml
MattGill98
suggested changes
Feb 25, 2019
...b-rest-remoting/admin/src/main/java/fish/payara/ejb/rest/admin/DisableEjbInvokerCommand.java
Outdated
Show resolved
Hide resolved
...jb-rest-remoting/admin/src/main/java/fish/payara/ejb/rest/admin/EnableEjbInvokerCommand.java
Show resolved
Hide resolved
...ejb/ejb-rest-remoting/client/src/main/java/fish/payara/ejb/rest/client/RemoteEJBContext.java
Show resolved
Hide resolved
...ejb/ejb-rest-remoting/client/src/main/java/fish/payara/ejb/rest/client/RemoteEJBContext.java
Outdated
Show resolved
Hide resolved
...-rest-remoting/client/src/main/java/fish/payara/ejb/rest/client/RemoteEJBContextFactory.java
Show resolved
Hide resolved
...er/ejb/ejb-rest-remoting/endpoint/src/main/java/fish/payara/ejb/invoke/InvokeEJBServlet.java
Outdated
Show resolved
Hide resolved
...er/ejb/ejb-rest-remoting/endpoint/src/main/java/fish/payara/ejb/invoke/InvokeEJBServlet.java
Show resolved
Hide resolved
Jenkins test please |
Jenkins test please |
MattGill98
approved these changes
Feb 26, 2019
Jenkins test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small amount of cleaning ahead of actual commits