PAYARA-4092: Put Strings into optionMap #4175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDK$Version caused JsonException when trying to serialize it
Pandrex247
approved these changes
Aug 23, 2019
jbee
approved these changes
Aug 23, 2019
|
Jenkins test please |
| @@ -258,16 +260,8 @@ protected ActionReportResult buildActionReportResult() { | |||
|
|
|||
| private Map<String, String> optionToMap(JvmOption option){ | |||
| Map baseMap = new HashMap<>(); | |||
There was a problem hiding this comment.
Cosmetic: Could this baseMap be a Map<String, String>? Sorry for being pedantic.
There was a problem hiding this comment.
Yes, thanks. It's not pedantic, it's right thing to do, but I didn't read that line while fixing :)
|
Jenkins test please |
1 similar comment
|
Jenkins test please |
Pandrex247
pushed a commit
that referenced
this pull request
Aug 27, 2019
PAYARA-4092: Put Strings into optionMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK$Version caused JsonException when trying to serialize it