FISH-761 Deployment of unpacked WAB fails when using Felix fileinstall #4440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdebusscher
added
the
PR: Awaiting CLA
|
@bjetal We are awaiting the signed CLA (https://github.com/payara/Payara/blob/master/PayaraCLA.pdf) otherwise we need to close this PR. |
rdebusscher
added
the
Status: Abandoned
|
I apologize, I thought I had emailed it, but in looking at it I realized I had sent it to the wrong email address. I have emailed it again, this time to the correct address. |
smillidge
added
PR: CLA
|
We've got the CLA |
rdebusscher
added
community-contribution
and removed
Status: Abandoned
dmatej
reviewed
Nov 13, 2020
nucleus/deployment/common/src/main/java/org/glassfish/loader/util/ASClassLoaderUtil.java
Outdated
Show resolved
Hide resolved
Pandrex247
approved these changes
Nov 17, 2020
nucleus/deployment/common/src/main/java/org/glassfish/loader/util/ASClassLoaderUtil.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Pielage <pandrex247@hotmail.com>
|
jenkins test please |
MeroRai
changed the title
MeroRai
added
the
Status: Accepted
Cousjava
pushed a commit
to Cousjava/Payara
that referenced
this pull request
Jan 27, 2021
FISH-761 Deployment of unpacked WAB fails when using Felix fileinstall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add explicit support for the "jardir" schema used by fileinstall for unpacked directories by translating it to to the "file" schema. This allows unpacked WAB (and probably EJB bundles) installed via Felix FileInstall to be deployed successfully (barring other bugs)
Fixes: #4415
This works because the path portion of the jardir: URL is the directory path. The "jardir:" provides some additional features that don't appear to be needed during Java EE module deployment and it isn't supported for the NIO FileSystem API, which Payara uses during deployment.
Testing
New tests
None added
Testing Performed
Tested this with the application under which we discovered this bug
Test suites executed
None
Testing Environment
OS: RedHat Linux 7
JDK: OpenJDK 8.0.201
Maven: 3.6.2
Documentation
N/A
Notes for Reviewers
N/A