Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUSTCOM-135 Fixed race condition on ConfigProviderResolver initialization #4480

Merged
merged 2 commits into from
Feb 11, 2020
Merged

CUSTCOM-135 Fixed race condition on ConfigProviderResolver initialization #4480

merged 2 commits into from
Feb 11, 2020

Commits on Feb 10, 2020

  1. CUSTCOM-135 Fixed race condition on ConfigProviderResolver initializa… 

    …tion

- instane() is synchronized
- setInstance is NOT synchronized, so it ignores any locks
- preferring @Inject over ConfigProvider in HealthCheckService
- using @ContractsProvided to allow both @Inject target types
- more logging, but only when configured
- tested in extremely slowed TestContainers docker container
    David Matejcek committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    e4a4c75 View commit details
    Browse the repository at this point in the history

  2. CUSTCOM-135 Code moved from constructor to postConstruct method 

    - safer, all fields should be set here.
    David Matejcek committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    a12e0db View commit details
    Browse the repository at this point in the history