FISH-660 Upgrade MicroProfile Health Implementation to 3.0-RC5 #4986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbee
reviewed
Nov 11, 2020
...ofile/healthcheck/src/main/java/fish/payara/microprofile/healthcheck/HealthCheckService.java
Outdated
Show resolved
Hide resolved
@health annotation has been removed, so the backward compatibility flag has also been removed. Signed-off-by: Matthew Gill <matthew.gill@live.co.uk>
This is a breaking change, but the MP health configuration was incorrectly called "metrics-healthcheck-configuration" which was confusing. Signed-off-by: Matthew Gill <matthew.gill@live.co.uk>
|
jenkins test please |
Monitoring still collected Health data, which has been removed. The 'overall' metric has also been renamed to health as it now feels more appropriate. Signed-off-by: Matthew Gill <matthew.gill@live.co.uk>
jbee
approved these changes
Nov 12, 2020
|
Jenkins test please |
|
jenkins test please |
1 similar comment
|
jenkins test please |
|
jenkins test please |
1 similar comment
|
jenkins test please |
|
Fails because the TCK is randomly downgraded, waiting on payara/MicroProfile-TCK-Runners#125 |
Conflicts arose caused by FISH-327 MP Sniffers. These are integrated into the Health upgrade. Signed-off-by: Matthew Gill <matthew.gill@live.co.uk>
|
jenkins test please |
1 similar comment
|
jenkins test please |
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Sep 17, 2021
FISH-660 Upgrade MicroProfile Health Implementation to 3.0-RC5
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Sep 17, 2021
FISH-660 Upgrade MicroProfile Health Implementation to 3.0-RC5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a feature. Will need upgrading to the final release version when it's release, but for now the release candidate is good enough.
Testing
New tests
TCK updated: payara/MicroProfile-TCK-Runners#122
Testing Performed
Ran the new TCK against our current implementation
Documentation
TBW
Notes for Reviewers