Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-5815 Allow Admin Console to Load under JDK 17 #5480

Merged
merged 5 commits into from Nov 2, 2021

Conversation

Pandrex247
Copy link
Member

Description

Adds the exports required by the current JACC impl to load the admin console under JDK 17.
The server was complaining about the PolicyParser and PolicyConfigurationImpl using the sun.security.util and sun.net.www packages respectively. GlassFish 6 appears to have completely stripped out these classes during their impl of Exousia.

Important Info

Blockers

Testing

New tests

None

Testing Performed

Started the admin console under JDK 8 - no errors
Started the admin console under JDK 11 - no errors
Started the admin console under JDK 17 - no errors

Testing Environment

Windows 10.
Zulu JDK 8u312, 11.0.13, and 17.0.1

Documentation

N/A

Notes for Reviewers

A branch with all changes combined is available here: https://github.com/Pandrex247/Payara/tree/FISH-5815

Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247
Copy link
Member Author

Jenkins test please

Copy link
Member

@JamesHillyard JamesHillyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Production domain templates need copyright updating. Tested on Windows 10, JDK 8 and 17.

Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247 Pandrex247 merged commit 54c35df into payara:master Nov 2, 2021
@Pandrex247 Pandrex247 deleted the FISH-5815-Rebase branch November 2, 2021 12:49
JamesHillyard pushed a commit to JamesHillyard/Payara that referenced this pull request Nov 18, 2021
FISH-5815 Allow Admin Console to Load under JDK 17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants