FISH-394 Upgrade ASM Opcodes #5526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test please |
Pandrex247
approved these changes
Dec 8, 2021
There was a problem hiding this comment.
Approved because these changes are fine, but...
With this, the aforementioned error is fixed, the actual reproducer still has failures, as for whether that is an issue with the reproducer or Payara, I'm not sure. I believe it would be a separate issue if Payara is the cause.
See comment on Jira - we need to confirm one way or the other if the EJBContainer is broken. At this point in time I'm against splitting this up into separate issues
|
jenkins test please |
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Jan 24, 2022
FISH-394 Upgrade ASM Opcodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running an embedded EJB container via a testing framework, the EJBContainer.createEJBContainer method will fail with the following stack trace:
java.lang.UnsupportedOperationException: Module requires ASM6 at org.objectweb.asm.ClassVisitor.visitModule(ClassVisitor.java:145) at org.objectweb.asm.ClassReader.readModuleAttributes(ClassReader.java:758) at org.objectweb.asm.ClassReader.accept(ClassReader.java:557) at org.objectweb.asm.ClassReader.accept(ClassReader.java:401) at org.glassfish.deployment.common.GenericAnnotationDetector.scanArchive(GenericAnnotationDetector.java:146) at org.glassfish.deployment.common.GenericAnnotationDetector.hasAnnotationInArchive(GenericAnnotationDetector.java:96) at org.glassfish.ejb.embedded.EJBContainerProviderImpl.getRequestedEJBModuleOrLibrary(EJBContainerProviderImpl.java:338) at org.glassfish.ejb.embedded.EJBContainerProviderImpl.addModule(EJBContainerProviderImpl.java:383) at org.glassfish.ejb.embedded.EJBContainerProviderImpl.addModules(EJBContainerProviderImpl.java:286) at org.glassfish.ejb.embedded.EJBContainerProviderImpl.createEJBContainer(EJBContainerProviderImpl.java:132) at javax.ejb.embeddable.EJBContainer.createEJBContainer(EJBContainer.java:103) at javax.ejb.embeddable.EJBContainer.createEJBContainer(EJBContainer.java:78)Important Info
Blockers
n/a
Testing
New tests
n/a
Testing Performed
built the reproducer with these changes in Payara.
Testing Environment
Apache Maven 3.6.3
Ubuntu 20.04
Build reproducer on openjdk version "11.0.11" 2021-04-20 LTS
Documentation
n/a
Notes for Reviewers
With this, the aforementioned error is fixed, the actual reproducer still has failures, as for whether that is an issue with the reproducer or Payara, I'm not sure. I believe it would be a separate issue if Payara is the cause.