FISH-5803 Added local commands option to generate-bash-autocomplete P6 #5624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added option to generate-bash-autocomplete command to include local commands
This option is disabled by default
Important Info
Blockers
N/A
Testing
New tests
N/A
Testing Performed
Built Payara, Started server and executed command with localCommands option set to true
Testing Environment
Apache Maven 3.6.3
Ubuntu 20.04
openjdk version "11.0.11" 2021-04-20 LTS
Documentation
payara/Payara-Community-Documentation#293
Notes for Reviewers
I got inspiration from
Payara/nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/AdminMain.java
Line 262 in cf883d8