FISH-5927 Document --installdir Command and Installation Directory for Docker Nodes #5637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JamesHillyard <james.hillyard@payara.fish>
Pandrex247
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An improvement to the DockerInstallDirHelp label, changing the label so this is clear the Installation Directory should be left as the default unless using a custom Docker image.
Important Info
Blockers
None
Testing
New tests
None
Testing Performed
Built the server, updated label is shown in the admin console for DOCKER Node Types.
Testing Environment
Windows 10, JDK 11, Maven 3.6.3
Documentation
The documentation surrounding this is already correct
Notes for Reviewers
None