FISH 6027 - Remote EJB + JDK 17 does not work #5664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes do not fix remote EJBs on JDK 17 directly, the suggested fix for this is to specify
--add-opens=java.base/java.lang=ALL-UNNAMEDto the invoking command as short of refactoring the IllegalReflectiveAccess there is no fix to this (See JIRA for more information)These changes instead specify this --add-opens to the remote-ejb-tracing sample which I identified is also broken due to this error.
These changes also add the parameter
-Dorg.glassfish.gmbal.no.multipleUpperBoundsException=trueto the GlassFishORBManager meaning it doesn't need to be specified by the client. This issue is explained here: eclipse-ee4j/orb-gmbal#22Important Info
Blockers
None
Testing
New tests
None
Testing Performed
Manually tested the fix against the reproducer in the community bug, my own reproducer and the remote-ejb-tracing sample. Tested the sample on JDK 8 to confirm the profile only activates on JDK 17+
Testing Environment
Windows 10, Zulu JDK 17 / Zulu JDK 8, Maven 3.6.3
Documentation
No documentation for Payara 6
Notes for Reviewers
Commit be90757 is cleaning up whitespace and fixing consistency within the GlassFishORBManager file and should be filtered out when reviewing changes.