FISH-5987 Remove TLS 1.0,1.1 SSL2 and SSL3 #5666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandrex247
requested changes
Mar 23, 2022
appserver/admingui/common/src/main/resources/shared/sslPrepare.inc
Outdated
Show resolved
Hide resolved
kalinchan
commented
Mar 23, 2022
...rver/orb/orb-iiop/src/main/java/org/glassfish/enterprise/iiop/impl/IIOPSSLSocketFactory.java
Outdated
Show resolved
Hide resolved
kalinchan
changed the title
Pandrex247
requested changes
Mar 28, 2022
|
|
||
| String protocol; | ||
| if (tlsEnabled13) { | ||
| protocol = TLS13; | ||
| } else if (tlsEnabled12) { | ||
| } else { |
There was a problem hiding this comment.
I wonder if this should default to 1.3, 1.2, or throw an error?
Need to debug with a reproducer to understand this and why it would originally default to SSL even though that wasn't an option.
|
|
Pandrex247
requested changes
Mar 30, 2022
....security/src/main/java/com/sun/enterprise/security/appclient/AppClientSecurityInfoImpl.java
Outdated
Show resolved
Hide resolved
Pandrex247
requested changes
Apr 1, 2022
Pandrex247
requested changes
Apr 13, 2022
...er/web/web-glue/src/main/java/com/sun/enterprise/web/connector/coyote/PECoyoteConnector.java
Outdated
Show resolved
Hide resolved
Pandrex247
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since TLS 1.0 and 1.1 are disabled on JDK 11, this has been removed
Important Info
Blockers
N/A
Testing
New tests
N/A
Testing Performed
Built Payara and checked if options for tls 1.0 and 1.1 were there and executed
set configs.config.server-config.network-config.protocols.protocol.${protocol-name}.ssl.tls-enabled=[true/false]Testing Environment
ubuntu 20.04 maven 3.6.3 openjdk 11.0.11 2021-04-20 LTS
Documentation
Here
Notes for Reviewers