Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish 5978 Set TLS 1.3 as Default Protocol #5675

Merged
merged 5 commits into from
Mar 29, 2022

Conversation

luiseufrasio
Copy link
Contributor

Description

Payara6 changed to handle https requests using TLSv1.3 as default

Important Info

Blockers

None

Testing

New tests

None

Testing Performed

  1. Build Payara6: mvn clean install -T 4 -DskipTests
  2. Run Payara6: .\appserver\distributions\payara\target\stage\payara6\bin\asadmin start-domain --verbose
  3. Open Google Chrome & press CTRL+Shift+i to open dev tools
  4. Make a request to https://localhost:8181/
  5. In dev tools go to "Security" sheet
  6. Verify if "connection" says "authenticated using TLS 1.3"

Testing Environment

Windows 10 (on Linux I think it will not work unless you have a certificate configured locally), JDK version "11.0.10" 2021-01-19 LTS, Maven 3.8.4"-->

Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than you need to update the copyright of the files you've edited - all but HttpConnectorAddress need the portions copyright line updated to the current year

Copy link
Member

@JamesHillyard JamesHillyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Admin Console TLS1.3 checkbox help text in the HTTP Listeners -> Any HTTP Listener -> SSL tab says: If you are using Zulu JDK 8, you will also need to add the following Java Option: -XX:+UseOpenJSSE. as Payara6 is JDK11+ this should be removed
image

Copy link
Member

@JamesHillyard JamesHillyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings.properties Needs copyright updating

@luiseufrasio luiseufrasio removed the request for review from kalinchan March 29, 2022 12:19
@luiseufrasio luiseufrasio merged commit 79b53d8 into payara:Payara6 Mar 29, 2022
@luiseufrasio luiseufrasio deleted the FISH-5978 branch March 29, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants