Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-5968 leave transaction intact if mentioned in unchanged parameter #5680

Conversation

aubi
Copy link
Contributor

@aubi aubi commented Mar 29, 2022

DescriptionFixes testContextServiceDefinitionAllAttributes TCK test, method ContextService.contextualFunction() with transaction defined as this:

@ContextServiceDefinition(name = "java:app/concurrent/ContextA",
                          propagated = { APPLICATION, IntContext.NAME },
                          cleared = StringContext.NAME,
                          unchanged = TRANSACTION)

Note the unchanged = TRANSACTION -- the transaction is now unchanged.

Important Info

Blockers

Testing

Testing Performed

Failing tests in package ee.jakarta.tck.concurrent.spec.ContextService.contextPropagate.* decreased from 9 to 6.

Testing Environment

Linux, OpenJDK

Notes for Reviewers

Requires current version of concurrencty-ri, branch jakarta10: aubi/concurrency-ri@7ce79fd

I accidentally moved the payara6-concurrency-3.0-upgrade branch, so this diff doesn't include the main commit of this PR:
aubi@65f0fd6

We do partial upgrades in concurrency.
@breakponchito breakponchito self-requested a review March 29, 2022 15:57
Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aubi
Copy link
Contributor Author

aubi commented Mar 30, 2022

I added few more changes, should help with parsing ManagedThreadFactoryDefinition

@breakponchito breakponchito merged commit 95caf8a into payara:payara6-concurrency-3.0-upgrade Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants