-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FISH-6110 Upgrade to latest H2 version (P6) #5762
Conversation
@@ -224,7 +224,7 @@ | |||
<payara-arquillian-container.version>3.0.alpha4</payara-arquillian-container.version> | |||
<payara.security-connectors.version>3.0.alpha4</payara.security-connectors.version> | |||
<opentracing.version>0.33.0</opentracing.version> | |||
<h2db.version>1.4.200</h2db.version> | |||
<h2db.version>2.1.212</h2db.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are using a patched version of h2db, the version should be the following
<h2db.version>2.1.212</h2db.version> | |
<h2db.version>2.1.212.payara-p1</h2db.version> |
I am also not seeing any changes in Payara's h2db project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is using patched binary by downloading .zip
file directly from H2 Github and then uploading it to Payara Nexus instead of using neither Payara's h2db project nor Payara_PatchedProjects that already deprecated. There is no change to the code, it is just a packager module in Payara that requires a .zip
package of the H2 dependency instead of .jar
package and some other dependencies need the 2.1.2121
version of H2 dependency from maven repository. So I believe it does not need to change the version to Payara patched version
jenkins test please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade h2db is working well with the sample app but found a new h2 directory in payara/h2db/h2
I've updated the h2db by removing the h2 sub-folder folder |
Description
Upgrade the H2 to 2.1.212 version. Repackage module in Payara requires a patched binary with zip file of H2, so I also have uploaded h2db 2.1.212 to payara-artifact
Important Info
Blockers
N/A
Testing
New tests
None
Testing Performed
Build and run Payara Server
Testing Environment
Windows 11, OpenJDK11, Maven 3.8.4
Documentation
N/A
Notes for Reviewers
None