Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-5808 : handling single @Path on methods #6048

Merged
merged 1 commit into from
Nov 17, 2022
Merged

FISH-5808 : handling single @Path on methods #6048

merged 1 commit into from
Nov 17, 2022

Conversation

luiseufrasio
Copy link
Contributor

Description

JAX-RS Subresources don't Appear in OpenAPI Document

Important Info

Blockers

None

Testing

New tests

new test dependantClassSinglePathAnnotation in fish.payara.microprofile.openapi.test.app.application.DependantClassesTest

Testing Performed

  1. mvn clean install -T 3C -DskipTests
  2. .\appserver\distributions\payara\target\stage\payara5\bin\asadmin start-domain
  3. cd C:\Dev\reproducers\FISH-5808
  4. C:\Dev\reproducers\FISH-5808\mvn clean install
  5. C:\Users\luise\git\Payara\appserver\distributions\payara\target\stage\payara5\bin\asadmin deploy .\openapi-test.war
  6. Poke http://localhost:8080/openapi
  7. It should show: /resources/foo/bar into paths & endpoints

Testing Environment

Zulu JDK 1.8_212 on Windows 10 with Maven 3.8.4

@luiseufrasio
Copy link
Contributor Author

jenkins test please

breakponchito
breakponchito approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luiseufrasio luiseufrasio merged commit 58aebb9 into payara:Payara6 Nov 17, 2022
@luiseufrasio luiseufrasio deleted the FISH-5808-Payara6 branch November 17, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breakponchito breakponchito breakponchito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luiseufrasio @breakponchito