Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-6432 Applications Take Longer To Deploy on JDK 11 and 17 (Payara 5.x) #6183

Merged
merged 1 commit into from Feb 6, 2023

Conversation

jGauravGupta
Copy link
Contributor

Description

In this PR, a few performance optimizations have been done.

  • File canonicalization cache is disabled by default in JDK 12 which helps in performance optimizations for file name canonicalization. In HK2, TypeImpl#addDefiningURI duplicate uri is added so canonicalization is not required.

Testing

Testing Performed

Manually with reproducer

Testing Environment

Windows 11, and WSL
JDK 11, 12, and 17

Depends on

payara/patched-src-hk2#29

@jGauravGupta jGauravGupta marked this pull request as ready for review February 2, 2023 11:16
@jGauravGupta
Copy link
Contributor Author

jenkins test please

@arieki
Copy link
Contributor

arieki commented Feb 3, 2023

I am not sure still need to do changes to Payara 5 community. I believe Payara 5 enterprise only required

@smillidge
Copy link
Contributor

No harm merging it in.

Copy link
Contributor

@arieki arieki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jGauravGupta jGauravGupta merged commit effb646 into payara:Payara5 Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants