FISH-7340 Remove obsolete EJBContext methods

[eirbjo]

The EJBContext methods getEnvironment, getCallerIdentity and isCallerInRole(Identity) were removed in Jakarta EE 9.

This PR removes these methods from EJBContextImpl.

Since this was probably caused by missing @Override annotations, I went ahead and added that for all overriding methods such that future removals may be detected.

Description

This is an enhancement which removes dead code and also allows Payara to compile on future JDKs where the deprecated Identity class has been removed.

Important Info

Testing

Testing Performed

Ran mvn clean install successfully.

Testing Environment

% mvn -v 
Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Maven home: /Users/eirbjo/Development/apache-maven-3.8.6
Java version: 11.0.18, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk-11.jdk/Contents/Home
OS name: "mac os x", version: "12.6.3", arch: "x86_64", family: "mac"

[JamesHillyard]

Hi @eirbjo,

Thank you for submitting a PR to remove these obsolete methods, it's much appreciated. The internal issue FISH-7340 has been raised to track your changes.

As I commented on your other contribution, #6267, we require you to sign the CLA and send it to us before we can review and accept your changes. Payara/PayaraCLA.pdf at master · payara/Payara

Thank you,
James

[eirbjo]

As I commented on your other contribution, #6267, we require you to sign the CLA

CLA signed, it will be good to get these removed. Here is the OpenJDK issue for the removal of java.security.Identity, in case you want to track that for your Payara 5 Enterprise offerings:

https://bugs.openjdk.org/browse/JDK-8191136

My testing on Payara 5 CE indicates it will run just fine since you throw unconditionally in both of the EJBContext methods taking java.security.Identity as parameter or return value.

[smillidge]

CLA received

[JamesHillyard]

Jenkins test please

[aubi]

Jenkins test please

[aubi]

@eirbjo,
Thank you for your PR! I updated the copyright year and if you don't mind, I did some formatting cleanup as we touch the file already...

[aubi]

Looks good, I didn't spot any problem this could cause.