FISH-7359 Fix change-master-password for JKS Keystores #6278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use p12 formats if available, otherwise jks. Report not existing keystores (breaks server setup).
|
Jenkins test please |
Pandrex247
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After Payara upgrade from P5 to P6, keystore and cacerts remain in the JKS format.
This PR fixes change-master-password command, so it accepts JKS keystores.
Testing
Testing Performed
I tried to use old domain with jks keystores (e.g. no p12 files in domain/config) and copied it to Payara from this PR.
Then try
Verification can be done with second run or with
keytoolin the domain/config directory:The new password is required.
Testing Environment
Linux, OpenJDK 8 and 11