FISH-7821 FISH-8190 Multiplatform Docker Images for Server and Micro #6530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
…ding multipaltform Server Docker images Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
… image Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
This reverts commit 3816fa6. It doesn't work, buildx hits an issue with deploying without doing the standard build first, even though it ends up building it again to deploy.
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
This makes the build complicated when using buildx due to the quirk that buildx cannot utilise the local image cache - it can only pull from a published registry. The server-base Dockerfile is now just folded into the other server dockerfiles. The downside to this is that the build for each image is now slower due to having to redo all of what the server-base image previously did for each image (server-full jdk11, server-full jdk17, server-full jdk21, server-web jdk11 etc.), and increases redundancy in the dockerfiles themselves. Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port of #6523 to release branch.
Important Info
Blockers
#6523
Testing
New tests
None
Testing Performed
See #6523 for full details, for this branch I just did
mvn clean install -PBuildDockerImages -pl :docker-images -amdand checked that it was built using buildx.Testing Environment
OpenSUSE Leap 15.5 WSL, Zulu JDK 11.0.21
Documentation
N/A
Notes for Reviewers
See #6523