Override HTTP and HTTPS ports via system properties #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jGauravGupta @abdulrahim458 Please take a look, easy fix :) |
|
@jGauravGupta @abdulrahim458 ping :) ping |
|
ping ping |
jGauravGupta
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Able to override http(s) ports with system properties
Currently,
adminHostandadminPortcan be overridden by system properties, but not http/https portsThis prevents TestContainers to function properly when creating Payara image with random ports in Docker.
Introduced new system properties
httpPorthttpsPortThese will override default ports gotten from the server