Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should be returning ResponseError for ContextV2::process_response #154

Closed
DanGould opened this issue Dec 28, 2023 · 0 comments
Closed

We should be returning ResponseError for ContextV2::process_response #154

DanGould opened this issue Dec 28, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@DanGould
Copy link
Contributor

This was changed for v1 but not v2.

https://github.com/payjoin/rust-payjoin/blob/26f0d06999606f68bbfab113cc43809c346fa087/payjoin/src/send/mod.rs#L690C42-L690C42
@DanGould DanGould added the bug Something isn't working label Dec 28, 2023
DanGould added a commit to DanGould/rust-payjoin that referenced this issue Dec 29, 2023
@DanGould
Fix payjoin#154 process_response return ResponseError
13d50f1
DanGould added a commit that referenced this issue Jan 3, 2024
@DanGould
Fix #154 process_response return ResponseError (#155)
96212cc 
Returns an option so that empty OK responses from the directory can
poll again for a response.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanGould