Fix #154 process_response return ResponseError
#155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbesraa
reviewed
Dec 29, 2023
| Ok(Some(psbt)) => return Ok(psbt), | ||
| Ok(None) => std::thread::sleep(std::time::Duration::from_secs(5)), | ||
| Err(re) => { | ||
| println!("{}", re); |
There was a problem hiding this comment.
is it? RE's display and debug impls are distinct
There was a problem hiding this comment.
why would we need both? aint the debug verbose enough?
There was a problem hiding this comment.
debug is verbose enough but in normal operation you the debug log is not printed to stdout. That only happens when debugging and manually setting RUST_LOG=debug
jbesraa
approved these changes
Dec 29, 2023
DanGould
commented
Dec 29, 2023
payjoin-cli/src/app.rs
Outdated
| @@ -195,6 +195,7 @@ impl App { | |||
|
|
|||
| #[cfg(feature = "v2")] | |||
| async fn long_poll_post(&self, req_ctx: &payjoin::send::RequestContext) -> Result<Psbt> { | |||
| use payjoin::send::ResponseError; | |||
There was a problem hiding this comment.
unused import @jbesraa soz I overlooked this
DanGould
force-pushed
the
fix-response-err
branch
from
13d50f1
to
3054ed8
Compare
|
@jbesraa I really want to merge this fix before we do the release. Please review, I ran |
This was referenced Jan 2, 2024
Closed
jbesraa
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns an option so that empty OK responses from the directory can poll again for a response.
The main v1 integration test handling these errors already seems sufficient to me. Ideally these v1/v2 code paths merge once we get achieve the Payjoin V2 Beta milestone.