add statement api #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darai0512
force-pushed
the
add-statement-master
branch
5 times, most recently
from
9721050
to
560584f
Compare
darai0512
commented
Jan 11, 2024
.github/workflows/main.yml
Outdated
| run: mvn install -Dgpg.skip=true | ||
| - name: Test | ||
| run: mvn test |
darai0512
commented
Jan 11, 2024
|
|
||
| * Init source. | ||
|
|
||
| Please see https://github.com/payjp/payjp-java/releases |
darai0512
commented
Jan 11, 2024
There was a problem hiding this comment.
16,17,21のサポートをしたいがmockitoの大幅ver up（とそれに伴うリファクタ）が必要
darai0512
commented
Jan 11, 2024
|
|
||
| * Init source. | ||
|
|
||
| Please see https://github.com/payjp/payjp-java/releases |
darai0512
commented
Jan 11, 2024
RequestExample.md
Outdated
There was a problem hiding this comment.
/docs/api に集約するため削除
darai0512
commented
Jan 11, 2024
| @@ -17,12 +17,6 @@ | |||
| <artifactId>jaxb-api</artifactId> | |||
| <version>2.3.0</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>com.google.guava</groupId> | |||
There was a problem hiding this comment.
vulnerabilitiesアラートが出ている。動いてないテストにのみ使用のためテストごと削除。
https://mvnrepository.com/artifact/jp.pay/payjp-java/0.6.1
darai0512
commented
Jan 11, 2024
| <source>1.6</source> | ||
| <target>1.6</target> | ||
| <source>1.8</source> | ||
| <target>1.8</target> |
There was a problem hiding this comment.
jdk >= 16に向けてあげておく
darai0512
commented
Jan 11, 2024
| @@ -44,7 +44,4 @@ public void setDeleted(Boolean deleted) { | |||
| public Boolean getLivemode() { | |||
| return livemode; | |||
| } | |||
| public void setLivemode(Boolean livemode) { | |||
| this.livemode = livemode; | |||
| } | |||
There was a problem hiding this comment.
参照のみの場所にsetがある、があちこちあるので目に見えたとこだけ削除
darai0512
commented
Jan 11, 2024
There was a problem hiding this comment.
参照のみの場所にsetがある、があちこちあるので目に見えたとこだけ削除
darai0512
commented
Jan 11, 2024
| @@ -65,23 +65,6 @@ public static <T> void verifyGet( | |||
| APIResource.RequestType.NORMAL, RequestOptions.getDefault()); | |||
| } | |||
|
|
|||
| public static <T> void verifyGet( | |||
darai0512
commented
Jan 11, 2024
| @@ -97,23 +80,6 @@ public static <T> void verifyPost( | |||
| APIResource.RequestType.NORMAL, RequestOptions.getDefault()); | |||
| } | |||
|
|
|||
| public static <T> void verifyPost( | |||
darai0512
commented
Jan 11, 2024
| package jp.pay; | ||
|
|
||
| import com.google.common.base.Joiner; |
There was a problem hiding this comment.
アラート出てるguava消すため（大した使い方してない）
darai0512
commented
Jan 11, 2024
There was a problem hiding this comment.
guava消すため。forループの中で使ってるけどforループが回ってない（＝ファイル全体で何もしてない）ので削除。
darai0512
force-pushed
the
add-statement-master
branch
from
560584f
to
0e97ab8
Compare
darai0512
force-pushed
the
add-statement-master
branch
from
0e97ab8
to
d2a7371
Compare
koki-matsuura-pay
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.