feat: only runs adminThumbnail func if image type

payloadcms · Mar 14, 2021 · 5e1ddb5 · 5e1ddb5
1 parent 521b49a
commit 5e1ddb5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/docs/upload/overview.mdx b/docs/upload/overview.mdx
@@ -133,6 +133,11 @@ const Media = {
 }
 ```
 
+<Banner>
+  <strong>Note:</strong><br/>
+  If you specify a function to return an admin thumbnail, but your upload is not an image file type (for example, PDF or TXT) your function will not be used. Instead, Payload will display its generic file upload graphic.
+</Banner>
+
 ### Uploading Files
 
 <Banner type="warning">

diff --git a/src/uploads/getThumbnail.ts b/src/uploads/getThumbnail.ts
@@ -15,11 +15,11 @@ const getThumbnail = (collection: CollectionConfig, doc: Record<string, unknown>
     filename,
   } = doc;
 
-  if (typeof adminThumbnail === 'function') {
-    return adminThumbnail({ doc });
-  }
-
   if (isImage(mimeType as string)) {
+    if (typeof adminThumbnail === 'function') {
+      return adminThumbnail({ doc });
+    }
+
     if (sizes?.[adminThumbnail]?.filename) {
       return `${staticURL}/${sizes[adminThumbnail].filename}`;
     }