fix: duplicate documents with required localized fields #4236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #4232
This changes how duplicating documents handles errors when other locales are present. The current behavior was creating a document, getting a success toast, then trying to patch each additional locale, if one failed the document was supposed to be deleted entirely. Instead it was not calling delete, so you'd have two toasts, one with a success, one with the validation error and the document would be partially copied.
With this change we always try and create a document and show the first error if it exists, then for every other locale, attempt to patch every other locale and only show one error at the end which lists all the locales that had trouble. Then finally, navigate to the duplicate document.
Type of change
Checklist: