Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): tooltip positioning issues #6439

Merged
merged 7 commits into from
May 20, 2024
Merged

fix(ui): tooltip positioning issues #6439

merged 7 commits into from
May 20, 2024

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented May 20, 2024

Description

  1. Removes these

CleanShot 2024-05-20 at 15 55 41

  1. Better performance when errors are shown, as the interaction observers are no longer running

  2. (Biggest change): properly displays field error tooltips if the field has no label (label: false).

Previous:

(Field label was just inserted at the top BELOW the top line. Without a label, that would be the toolbar)
CleanShot 2024-05-20 at 15 57 34

Now:

Field label is now inserted ABOVE the top line, not below.

CleanShot 2024-05-20 at 15 57 10

In case there is a label, I had to wrap the field error in a relative-positioned div which does NOT contain the label. Otherwise, the error tooltip would be displayed above the label, which would be weird.

CleanShot 2024-05-20 at 16 01 29

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Chore (non-breaking change which does not add functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to the templates directory (does not affect core functionality)
  • Change to the examples directory (does not affect core functionality)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@AlessioGr AlessioGr enabled auto-merge (squash) May 20, 2024 20:31
@AlessioGr AlessioGr merged commit ed47661 into beta May 20, 2024
36 checks passed
@AlessioGr AlessioGr deleted the fix/tooltips branch May 20, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant