Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fields): adds upload's relationship thumbnail #5015

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rklos
Copy link
Contributor

@rklos rklos commented Feb 7, 2024

Description

I've done an implementation of the feature requested here: #3407

Before:
CleanShot 2024-02-07 at 00 39 47

After:
CleanShot 2024-02-07 at 00 40 17

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes

@rklos
Copy link
Contributor Author

rklos commented Feb 7, 2024

Maybe we should add this as an option in the config?

@revnelson
Copy link

Maybe we should add this as an option in the config?

Yeah, in the referenced post I was thinking that this should be the default behavior for upload relationships (unless someone can explain why some other option would be a more generally-desired display) with options to set any field on that relationship instead.

It'd also be nice if the File and Thumbnail components were exported to be used with documentation on how to use them, because I didn't even know where those were until this pull request (thanks, BTW!). I found them and imported them to use manually in the admin>components>Cell field, but after some logging I can see that only the related ID is available in the row data (not the full object) so the thumbnail isn't working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants