Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct createPayloadRequest routeParams #6059

Merged
merged 2 commits into from
Apr 26, 2024
Merged

fix: correct createPayloadRequest routeParams #6059

merged 2 commits into from
Apr 26, 2024

Conversation

JarrodMFlesch
Copy link
Contributor

@JarrodMFlesch JarrodMFlesch commented Apr 26, 2024 •
edited

Description

Properly sets routeParams based on collection or global route.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@JarrodMFlesch JarrodMFlesch changed the title chore: improve createPayloadRequest routeParams fix: correct createPayloadRequest routeParams Apr 26, 2024
@JarrodMFlesch JarrodMFlesch merged commit fab9e32 into beta Apr 26, 2024
32 of 33 checks passed
@JarrodMFlesch JarrodMFlesch deleted the fix/beta/cpr-routeParams branch April 26, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denolfe denolfe Awaiting requested review from denolfe denolfe is a code owner

@jmikrut jmikrut Awaiting requested review from jmikrut jmikrut is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JarrodMFlesch