Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db-postgres): query with like on id columns #6414

Merged
merged 3 commits into from
May 17, 2024
Merged

Conversation

DanRibbens
Copy link
Contributor

Description

When typing into the search input on the list view of a collection, the like operator is used for id which causes an error for postgres. To fix this we are sanitizing the like for number or uuid fields to instead be an equals operator. An alternate solution would have been to cast the ids to text id::text but this would have performence implications on larger data sets.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@denolfe denolfe merged commit 12c812d into beta May 17, 2024
34 of 35 checks passed
@denolfe denolfe deleted the fix/id-like-queries branch May 17, 2024 18:09
JessChowdhury pushed a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants