Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: separate collection docs with same ids were excluded in selectable #6499

Merged
merged 1 commit into from
May 24, 2024

Conversation

JarrodMFlesch
Copy link
Contributor

@JarrodMFlesch JarrodMFlesch commented May 24, 2024

Description

Fixes #6370

When a relationship field that is related to many collections and 2 documents have the same ID, after selecting one they both would be absent in the list of available options.

This implements getOptionValue so values stored internally by react-select are unique by relationship collection.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@JarrodMFlesch JarrodMFlesch changed the title fix: separate collections with same ids were excluded in selectable fix: separate collection docs with same ids were excluded in selectable May 24, 2024
@JarrodMFlesch JarrodMFlesch merged commit 18bc4b7 into beta May 24, 2024
48 of 49 checks passed
@JarrodMFlesch JarrodMFlesch deleted the fix/beta/relationship-select-unique-values branch May 24, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant