fix(ui): react-datepicker inserting invalid require("react") calls in our bundle #6833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See code comments for description
Fixes #6828
Webpack before this PR:
✓ Starting...
✓ Ready in 2.2s
○ Compiling / ...
✓ Compiled / in 1978ms (520 modules)
GET / 200 in 2082ms
○ Compiling /admin/[[...segments]] ...
✓ Compiled /admin/[[...segments]] in 7.2s (5105 modules)
[11:35:52] WARN: No email adapter provided. Email will be written to console. More info at https://payloadcms.com/docs/email/overview.
GET /admin 200 in 8932ms
GET /admin 200 in 232ms
○ Compiling /api/[...slug] ...
✓ Compiled /api/[...slug] in 2.1s (4096 modules)
GET /admin 200 in 2817ms
Webpack after this PR:
✓ Ready in 2.1s
○ Compiling / ...
✓ Compiled / in 2s (520 modules)
GET / 200 in 2115ms
○ Compiling /admin/[[...segments]] ...
✓ Compiled /admin/[[...segments]] in 7.3s (5105 modules)
[11:46:40] WARN: No email adapter provided. Email will be written to console. More info at https://payloadcms.com/docs/email/overview.
GET /admin/collections/pages 200 in 8927ms
GET /admin/collections/pages 200 in 119ms
GET /admin/collections/pages 200 in 160ms
○ Compiling /api/[...slug] ...
✓ Compiled /api/[...slug] in 945ms (4096 modules)