Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Incorrect type definition #37

Closed
ChristopherNowlan opened this issue May 15, 2023 · 3 comments · Fixed by #41
Closed

Incorrect type definition #37

ChristopherNowlan opened this issue May 15, 2023 · 3 comments · Fixed by #41

Comments

@ChristopherNowlan
Copy link

https://github.com/payloadcms/plugin-form-builder/blob/main/src/types.ts

The type definitions for a width is a string should it not be a number? Because when you generate types within a payload project width is set to be a number for form field types

@jacobsfletch
Copy link
Member

jacobsfletch commented May 15, 2023

@ChristopherNowlan you're exactly right, here's the code that sets that field. And as seen here in the generated types from the demo, that field is typed as number as you suggest.

I opened a PR #41 for this just now. I'll be publishing a new release today (maybe a pre-release). THANK YOU!! 👍

@ChristopherNowlan
Copy link
Author

No worries. Love the work you and the team are doing on payload

@jacobsfletch
Copy link
Member

This was just released in v1.0.14 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants