Implement Windows support (issue #53) #60
Conversation
Fix os.path.samefile() usage on Windows + python 2.
|
Hi Martin and thanks for the effort you've put into this pull request! It's funny, I was recently looking into AppVeyor for testing several of my Python projects on Windows (pip‑accel being one of those projects) and here you are wanting to run pip‑accel itself on AppVeyor just a few weeks later :-). I'm planning to get this pull request merged this week. I've already started but won't finish it tonight and I thought I should let you know instead of leaving you waiting without feedback. |
======================================================================
ERROR: test_environment_validation (pip_accel.tests.PipAccelTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "c:\projects\pip-accel\pip_accel\tests.py", line 150, in test_environment_validation
os.environ['VIRTUAL_ENV'] = original_value
File "C:\Python27\lib\os.py", line 422, in __setitem__
putenv(key, item)
TypeError: must be string, not None
======================================================================
https://ci.appveyor.com/project/xolox/pip-accel/build/1.0.14#L185
This is needed because the previous test package (verboselogs) didn't have wheel distributions available while the new test package (pep8) does have wheels available. This pulls in setuptools >= 0.8 which breaks the test's assumptions (which were previously valid and are once again valid with this change). For reference: https://travis-ci.org/paylogic/pip-accel/jobs/87729211
This is needed because the previous test package (verboselogs) didn't have wheel distributions available while the new test package (pep8) does have wheels available. This pulls in setuptools >= 0.8 which breaks the test's assumptions (which were previously valid and are once again valid with this change). For reference: https://travis-ci.org/paylogic/pip-accel/jobs/87738788
On Python 2.6 tar file objects don't support being used as context managers. The easiest way to fix this is to bypass the syntactic sugar while keeping the semantics using a try/finally construct. For reference: https://travis-ci.org/paylogic/pip-accel/builds/87742226
|
For posterity: I'm working on setting up AppVeyor CI for pip-accel because I don't want to claim support for a platform I can't actually test, I don't have access to any Windows systems and I don't feel like paying for a Windows license just so I can test an open source project. Fortunately AppVeyor is free for open source projects which is pretty cool :-). |
|
@xolox This is appveyor project where I use |
Continuation of refactoring/cleanup of changes proposed in this pull request: #60
|
Hi again Martin, After some intense Windows testing and debugging (last time I did that was quite a few years ago :-) I released pip-accel 0.33 to PyPI and GitHub. If you're interested in the additional changes I made (quite a few) you can take a look at pull request #61 (which included the changes from this pull request). If you encounter any further Windows issues feel free to open another issue. Thanks for your contribution! |
|
@xolox Thanks for integrating and cleaning up windows support. |
I tried to implement Windows support #53