Update checksum models #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2015 14:10
| */ | ||
| public function validateResponse($response) | ||
| { | ||
| $returnValue = false; | ||
| if ($response['header']['status'] == 200) { |
There was a problem hiding this comment.
this change is not backwards compatible, the new version of the wrapper should be 4.0.0
There was a problem hiding this comment.
It is. It won't break existing implementations. It removed warnings if index isn't set and extends the range. Maybe I overlooked something, but what makes it not backwards compatible?
There was a problem hiding this comment.
Because of the handling implemented on the merchants side. A response != 20000 was nerver valid until now. Valid could be implement as success, which is not the case any more.
There was a problem hiding this comment.
You're right. 4.0.0 it is.
christian-kolb
added a commit
that referenced
this pull request
Jun 15, 2015
4.0.0 Added shipping and billing address Added shopping cart (items) Added PayPal functionality Possible BC break in ResponseHandler.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapper updates due to the latest API updates.