Update CreatePlan.php

[MartyIX]

No description provided.

[coveralls]

Coverage remained the same at 72.43% when pulling bfd3016 on MartyIX:patch-2 into c269976 on paypal:master.

[jziaja]

The frequency property is case-insensitive and will accept either "Month" or "MONTH". Also, if you pass in "MONTH", you'll currently get back "Month" from the API.

[MartyIX]

PaymentDefinition.php file contains the following phpdoc:

/**
 * Frequency of the payment definition offered. Allowed values: `WEEK`, `DAY`, `YEAR`, `MONTH`.
 *
 * @param string $frequency
 * 
 * @return $this
 */
public function setFrequency($frequency)
{
    $this->frequency = $frequency;
    return $this;
}

It seems to me that the naming should follow one convention to prevent possible confusion. However, it is just a suggestion. I can close the pull request. It is not something important to me.

[jziaja]

Sorry, wasn't trying to say it was a bad suggestion. :) I prefer the consistency of having it be all caps, but I just wanted to point out that that field happens to accept any case format when making the API call. In the .NET SDK sample for creating a billing plan, I have this field specified as all caps as well.

[MartyIX]

I see. Thank you for the explanation.

[jaypatel512]

Hey @MartyIX !! I will unfortunately not accept this PR. Even though you are right. These constants should be CAPITALIZED ! :P

However, the response from server is Camel Cased, and we would want to keep it that way. But I will definitely raise this issue internally, to see if we could have all CAPS accepted in Server Side code.

Thanks.